Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove store type aliases #10295

Merged
merged 23 commits into from
Oct 4, 2021

Conversation

iverc
Copy link
Contributor

@iverc iverc commented Oct 3, 2021

Description

Closes: #9362


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@iverc iverc changed the title Refactor store type aliases | #9362 | refactor:store type aliases | #9362 Oct 3, 2021
@iverc iverc changed the title refactor:store type aliases | #9362 refactor: Remove store type aliases Oct 3, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

server/mock/app.go Outdated Show resolved Hide resolved
server/mock/store_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #10295 (9fc7fd8) into master (dcf67d7) will increase coverage by 0.00%.
The diff coverage is 47.36%.

❗ Current head 9fc7fd8 differs from pull request most recent head fbb9e9e. Consider uploading reports for the commit fbb9e9e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10295   +/-   ##
=======================================
  Coverage   63.73%   63.74%           
=======================================
  Files         572      570    -2     
  Lines       53966    53904   -62     
=======================================
- Hits        34397    34360   -37     
+ Misses      17612    17588   -24     
+ Partials     1957     1956    -1     
Impacted Files Coverage Δ
testutil/context.go 0.00% <0.00%> (ø)
x/auth/keeper/keeper.go 67.27% <ø> (ø)
x/bank/keeper/keeper.go 72.75% <ø> (ø)
x/bank/keeper/send.go 82.98% <ø> (ø)
x/distribution/keeper/keeper.go 81.98% <ø> (ø)
x/evidence/keeper/keeper.go 87.35% <ø> (ø)
x/gov/keeper/keeper.go 80.00% <ø> (ø)
x/gov/keeper/msg_server.go 1.53% <0.00%> (ø)
x/mint/keeper/keeper.go 60.00% <ø> (ø)
x/staking/keeper/keeper.go 57.50% <ø> (ø)
... and 29 more

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. and removed A:automerge Automatically merge PR once all prerequisites pass. labels Oct 4, 2021
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 4, 2021
@mergify mergify bot merged commit d07e416 into cosmos:master Oct 4, 2021
@iverc iverc deleted the refactor-store-type-aliases branch October 4, 2021 17:03
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: cosmos#9362

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [X] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [X] added `!` to the type prefix if API or client breaking change
- [X] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [X] provided a link to the relevant issue or specification
- [X] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [X] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [X] added a changelog entry to `CHANGELOG.md`
- [X] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [X] updated the relevant documentation or specification
- [X] reviewed "Files changed" and left comments if necessary
- [X] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove store type aliases in /types
4 participants