fix: x/bank/044 migrateDenomMetadata #10239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
aaronc and
alexanderbez
as code owners
robert-zaremba
requested review from
technicallyty,
aleem1314,
anilcse and
clevinson
robert-zaremba
added
A:automerge
|
Adding a backport/0.44.x label. |
Codecov Report
@@ Coverage Diff @@
## master #10239 +/- ##
==========================================
+ Coverage 63.65% 63.67% +0.01%
==========================================
Files 573 573
Lines 53796 53807 +11
==========================================
+ Hits 34245 34260 +15
+ Misses 17602 17598 -4
Partials 1949 1949
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
* fix: x/bank/044 migrateDenomMetadata * adding changelog entry * comment update * fix tests (cherry picked from commit 16a953c) # Conflicts: # CHANGELOG.md # x/bank/migrations/v044/keys.go # x/bank/migrations/v044/store.go # x/bank/migrations/v044/store_test.go # x/bank/types/key.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #10060
Fixing x/bank/migrations/v44.migrateDenomMetadata - we could potentially put a wrong data in a new key if the old keys have variable length.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change