-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert TxFactory changes #10053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit https://dashboard.github.orijtech.com?back=0&pr=10053&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
github-actions
bot
added
C:CLI
C:Cosmovisor
Issues and PR related to Cosmovisor
C:Keys
Keybase, KMS and HSMs
C:Simulations
C:x/auth
C:x/bank
C:x/capability
C:x/distribution
distribution module related
C:x/feegrant
C:x/genutil
genutil module issues
C:x/staking
C:x/upgrade
Type: Build
labels
Sep 1, 2021
robert-zaremba
removed
C:x/staking
C:Keys
Keybase, KMS and HSMs
C:x/distribution
distribution module related
C:Simulations
C:x/upgrade
C:x/feegrant
C:x/capability
C:x/genutil
genutil module issues
C:Cosmovisor
Issues and PR related to Cosmovisor
labels
Sep 1, 2021
clevinson
approved these changes
Sep 1, 2021
clevinson
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Sep 1, 2021
6 tasks
evan-forbes
pushed a commit
to evan-forbes/cosmos-sdk
that referenced
this pull request
Oct 12, 2021
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog
evan-forbes
pushed a commit
to evan-forbes/cosmos-sdk
that referenced
this pull request
Nov 1, 2021
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
* Revert "refactor: Move some methods inside TX Factory (backport cosmos#9421) (cosmos#10039)" This reverts commit 0155244. * remove conflict marks from changelog * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
C:x/auth
C:x/genutil
genutil module issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since don't remove all legacy REST endpoints we don't need the 0155244 commit which breaks the API. Let's keep the v0.44 changes to the absolute minimum.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change