Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove legacy REST endpoints for broadcast & encode (v0.44.x) #10041

Merged

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Sep 1, 2021

Description

This PR removes legacy REST endpoints for broadcast & encode in order for #10029 to be backported successfully to v0.44 (#10034).

It is essentially a partial backport of #9594 which removed all legacy REST endpoints (already merged on master).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@clevinson clevinson changed the title fix: remove legacy REST endpoints for broadcast & encode fix: remove legacy REST endpoints for broadcast & encode (v0.44.x) Sep 1, 2021
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@robert-zaremba
Copy link
Collaborator

There are few tests failing, I will check them

@orijbot
Copy link

orijbot commented Sep 1, 2021

@robert-zaremba
Copy link
Collaborator

I was trying to fix the tests in x/auth/client/rest/rest_test.go in the end I removed it: 1cfa714

@robert-zaremba robert-zaremba merged commit c1fc2a3 into release/v0.44.x Sep 1, 2021
@robert-zaremba robert-zaremba deleted the clevinson/rm-legacy-broadcast-encode branch September 1, 2021 13:50
@colin-axner
Copy link
Contributor

colin-axner commented Sep 1, 2021

Looks like I can remove this test on ibc-go which we were hosting for the sdk. Our sdk_test.go folder contains test we needed to migrate with us since they required IBC to test certain cases. Just want to double check I follow these changes correctly. Looks like this test can be removed as well

@colin-axner colin-axner mentioned this pull request Sep 2, 2021
9 tasks
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Oct 12, 2021
…osmos#10041)

* fix: remove legacy REST endpoints for broadcast & encode

* add changelog

* update changelog

* fix amino tx marshaling test

* try to fix x/auth/client/rest tests

* changing tx broadcast request type

* remove auth client/rest_test.go

Co-authored-by: Robert Zaremba <[email protected]>
evan-forbes pushed a commit to evan-forbes/cosmos-sdk that referenced this pull request Nov 1, 2021
…osmos#10041)

* fix: remove legacy REST endpoints for broadcast & encode

* add changelog

* update changelog

* fix amino tx marshaling test

* try to fix x/auth/client/rest tests

* changing tx broadcast request type

* remove auth client/rest_test.go

Co-authored-by: Robert Zaremba <[email protected]>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
…osmos#10041)

* fix: remove legacy REST endpoints for broadcast & encode

* add changelog

* update changelog

* fix amino tx marshaling test

* try to fix x/auth/client/rest tests

* changing tx broadcast request type

* remove auth client/rest_test.go

Co-authored-by: Robert Zaremba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants