Generating amino rest tx errors due to not using broadcast mode option

[timlind]

Summary of Bug

Generating a transaction through the CLI to be submitted through to a custom legacy rest API errors with

{"error":"unsupported return type block|sync|async; supported types: sync, async, block"}*

When amino flag is used the broadcast mode is set to an unsupported value:

cosmos-sdk/x/auth/client/cli/tx_sign.go

Line 258 in 84c3321

req := rest.BroadcastReq{

cosmos-sdk/client/broadcast.go

Line 35 in 7648bfc

return nil, fmt.Errorf("unsupported return type %s; supported types: sync, async, block", ctx.BroadcastMode)

Version

v42.3

This code looks the same in master.

Steps to Reproduce

noded tx modulex txy --from $(noded keys show -a somekey) --generate-only --chain-id localnet -o json > tx.json

noded tx sign tx.json --from somekey --chain-id localnet --amino --broadcast-mode=async --sign-mode amino-json > tx-signed.json

The signed tx json has mode set to "async|sync|broadcast" and needs to be edited manually to avoid error.

curl http://localhost:1317/txs --data @tx-signed.json -H "content-type: application/json" -v

{"error":"unsupported return type block|sync|async; supported types: sync, async, block"}*

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

cosmos-sdk/x/auth/client/cli/tx_sign.go

Line 260 in 84c3321

Mode: "block|sync|async",

Well that doesn't look right at all 😆