Track delegation not work for vesting account

[cyborgshead]

Summary of Bug

Delegation (and undelegation) from vesting account are not tracked. I tried to make delegation from account (in my case periodic vesting account) and found that there are no updates to delegated vesting amount.
Looking to the code, there is not SetAccount here

Note: it was worked in 0.39.0

Version

SDK 0.41.0

Steps to Reproduce

1. Vest some account's tokens
2. Make delegation from this account

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[amaury1093]

@litvintech Would you like to create a PR with a test?

[alexanderbez]

Continuous and delayed accounts do track delegations and undelegations. I cannot speak for periodic account types because that was an external contribution.

[alessio]

Thank you very much for taking the time to file this issue and contribute to making Cosmos SDK better.

@litvintech dixit:

Looking to the code, there is not SetAccount here

True that, and yet addCoins() is called here:

cosmos-sdk/x/bank/keeper/keeper.go

Line 367 in 8f7cdaf

err := k.addCoins(ctx, acc.GetAddress(), amt)

addCoins() subsequently calls setBalance():

cosmos-sdk/x/bank/keeper/send.go

Line 216 in 8f7cdaf

err := k.setBalance(ctx, addr, newBalance)

Which in turn sets the new balance for the account:

cosmos-sdk/x/bank/keeper/send.go

Line 270 in 8f7cdaf

accountStore.Set([]byte(balance.Denom), bz)

@litvintech can you write a test case, please? Meanwhile, I'm labeling this accordingly.

[karzak]

Continuous and delayed accounts do track delegations and undelegations. I cannot speak for periodic account types because that was an external contribution.

Haven't used v0.41, but PeriodVestingAccount delegation tracking works on v0.39 and it looks to me like it should track delegations as normal here:

cosmos-sdk/x/bank/keeper/keeper.go

Line 117 in 4b4768d

if err := k.trackDelegation(ctx, delegatorAddr, balances, amt); err != nil {

cosmos-sdk/x/bank/keeper/keeper.go

Line 423 in 4b4768d

func (k BaseKeeper) trackDelegation(ctx sdk.Context, addr sdk.AccAddress, balance, amt sdk.Coins) error {