nothing should depend on anything in the examples directory!

[rigelrozanski]

https://github.com/cosmos/cosmos-sdk/blob/cd91b8385433371bbddc8b0e2f8eae75a3634790/client/lcd/lcd_test.go#L33

This is part of client refactor I guess

[adrianbrink]

cmd/gaiad/main.go
14:     "github.com/cosmos/cosmos-sdk/examples/basecoin/app"

baseapp/doc.go
8:See examples/basecoin/app/* for usage.

cmd/gaiacli/main.go
22:     "github.com/cosmos/cosmos-sdk/examples/basecoin/app"
23:     "github.com/cosmos/cosmos-sdk/examples/basecoin/types"

docs/basecoin/extensions.rst
204:For more examples and inspiration, see our `repository of example
205:plugins <https://github.com/tendermint/basecoin-examples>`__.

docs/sdk/overview.rst
85:In the Cosmos SDK, you can see the application of this principle in the basecoin examples folder.
89:    // File: cosmos-sdk/examples/basecoin/app/init_handlers.go
110:For examples, see the `examples <https://github.com/cosmos/cosmos-sdk/tree/develop/examples>`__ directory.
361:    // File: cosmos-sdk/examples/basecoin/app/init_stores.go
368:    // File: cosmos-sdk/examples/basecoin/app/init_handlers.go

x/auth/baseaccount.go
19:// See the examples/basecoin/types/account.go for an example.

client/lcd/lcd_test.go
35:     bapp "github.com/cosmos/cosmos-sdk/examples/basecoin/app"
36:     btypes "github.com/cosmos/cosmos-sdk/examples/basecoin/types"

[martindale]

@adrianbrink can you provide some updates on this? What is remaining?

[adrianbrink]

The lcd_tests.go file is the only place that relies on cosmos-sdk/examples. It needs to test the light-client against an actual application and hence sets up the entire stack (Tendermint Core, Basecoin, Lcd).

I don't think we should remove this reliance. If/When we refactor the light-client we should keep this reliance in mind though.

[adrianbrink]

@rigelrozanski What do you think?

[rigelrozanski]

Nah we need to remove this dependancy - we really need a way for modules (and apparently lcd) to create their own applications on the fly - this should be a part of the mock application. If you don't have the capacity to tackle this issue now that's fine - but we need to leave it open until this is able to get resolved

[rigelrozanski]

^ more over - There are a number of app tests in the examples directory and gaia which should actually not be in the application directory but in a specific module directories (if we were to do this right now that would introduce a bunch more dependancies on basecoin) - it's all connected man

[ebuchman]

Nothing outside examples imports examples anymore

[rigelrozanski]

There is one last dependancy on the cmd/ (technically different, but we don't want that dep for the same reason) but it's fine because we have this new issue which should address it: #1553