-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock Application For LCD / move lcd tests to modules #1553
Labels
Comments
This was referenced Jul 5, 2018
Closed
@rigelrozanski Will move staking LCD tests to the |
@fedekunze you should sync with @ebuchman if you are going to be making any radical changes - ALSO I kind of think we should either do it for ALL of the lcd tests simultaneously or just hold-off - I don't want a disjointed code base, I think that gets confusing |
Ok, makes sense |
4 tasks
Closing as we now have contract tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similarly to how the module-specific application-level tests for transactions formerly in
cmd/gaia/app/app_test.go
where moved into their respective modules through the use of a mock application - The LCD tests currently housed inclient/lcd/lcd_test.go
should be moved into their respective module packages.This also means restructuring
client/lcd/test_helpers.go
to not import thecmd/gaia/app
and instead allowing each module-lcd test to define its own mock application to test within.Ideally we can simple adapt the existing mock application framework used for
app_tests
to satisfy use in the lcd tests as well.checkout the app_test: https://github.com/cosmos/cosmos-sdk/blob/develop/x/stake/app_test.go
checkout the existing mock framework: https://github.com/cosmos/cosmos-sdk/tree/develop/x/mock
CC: @adrianbrink @dev @alexanderbez
The text was updated successfully, but these errors were encountered: