Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect error #671

Closed
chengwenxi opened this issue Mar 20, 2018 · 4 comments
Closed

connect error #671

chengwenxi opened this issue Mar 20, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@chengwenxi
Copy link
Contributor

Hi, the rest-server and client command will create a new HTTP rpcclient for each requst(e.g. /query/stake/candidates), much requst will cause connect error(cannot assign requested address)

@kidinamoto01
Copy link
Contributor

khezjqhfucqcsedotsghclxm

Gaia rest client will create a new HTTP Client for every query, this can lead to connection overflow easily.

@melekes any thoughts on preventing this?

^^

@martindale martindale added this to the Staking milestone Mar 27, 2018
@cwgoes cwgoes self-assigned this Apr 2, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Apr 2, 2018

Do we want to reuse the same rpcclient instance for all calls (was there a particular reason for the current implementation not reusing the same client)?

@ebuchman
Copy link
Member

ebuchman commented Apr 2, 2018

Yes let's reuse it for all the calls. The current implementation was hacked together in haste by the UI team in order to unblock the UI team :P

@ebuchman
Copy link
Member

ebuchman commented Apr 5, 2018

Should be fixed on develop

@ebuchman ebuchman closed this as completed Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants