Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live API on SwaggerHub #525

Closed
faboweb opened this issue Feb 28, 2018 · 7 comments
Closed

Live API on SwaggerHub #525

faboweb opened this issue Feb 28, 2018 · 7 comments
Labels
T:Docs Changes and features related to documentation.

Comments

@faboweb
Copy link
Contributor

faboweb commented Feb 28, 2018

The idea is to have links to the API on SwaggerHhub that reflect the versions of the API definition on develop and master on GitHub.

SwaggerHub has such features, but we need to downgrade the specification from version 3 to version 2 of the OpenAPI spec.

See: https://app.swaggerhub.com/help/integrations/github-sync > Considerations

Reference: #383

@martindale martindale added this to the Completed Documentation milestone Mar 8, 2018
@zramsay
Copy link
Contributor

zramsay commented May 23, 2018

can we use Slate? it's what we're using for Tendermint

@faboweb
Copy link
Contributor Author

faboweb commented May 23, 2018

Good idea to consolidate tools. Why did you choose Slate over OpenAPI though?

@zramsay
Copy link
Contributor

zramsay commented May 23, 2018

no reason in particular. When I joined the company, Anton had just done: tendermint/tendermint#526 so when folks starting asking for RPC docs (tendermint/tendermint#691), sticking with Slate made the most sense.

@faboweb
Copy link
Contributor Author

faboweb commented May 23, 2018

OpenAPI (Swagger) has the advantage, that you can directly use the queries against a node making it easy to play around or test the API.
If this is all too fancy to have, I am OK with consolidating tools and use Slate. Let's definitely choose one API documentation tool.

@faboweb
Copy link
Contributor Author

faboweb commented May 23, 2018

Zach and I agreed to try to use Slate for all API documentation as Slate is already setup and integrates into the code.

@zramsay
Copy link
Contributor

zramsay commented May 23, 2018

update: neither of us has used both sufficiently to judge the pros and cons ... so we're gonna run with both for the time being and re-evaluate in the future

@zramsay zramsay added T:Docs Changes and features related to documentation. and removed S:proposed labels May 23, 2018
@ebuchman ebuchman removed this from the Completed Documentation milestone Jul 11, 2018
@cwgoes
Copy link
Contributor

cwgoes commented Aug 31, 2018

Closing as this discussion no longer reflects the state of the SDK documentation - please continue discussion in #1020, #1460, or #2137.

@cwgoes cwgoes closed this as completed Aug 31, 2018
MSalopek pushed a commit to MSalopek/cosmos-sdk that referenced this issue Apr 12, 2024
* CacheKV speedups

* Remove extra btree alloc

---------

Co-authored-by: Dev Ojha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

No branches or pull requests

6 participants