Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: gaiakeyutil -> gaiacli keys parse #4228

Merged
merged 13 commits into from
May 2, 2019
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 29, 2019

Incorporate gaiakeyutil functionalities into gaiacli.

We would neither build nor install gaiakeyutil anymore, key string simple parsing functionality would be merged into gaiacli keys parse.

This is a call for a preliminary review, pending entry will eventually be added.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Incorporate gaiakeyutil functionalities into gaiacli.
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #4228 into master will increase coverage by 0.07%.
The diff coverage is 75.8%.

@@            Coverage Diff             @@
##           master    #4228      +/-   ##
==========================================
+ Coverage   60.16%   60.24%   +0.07%     
==========================================
  Files         212      213       +1     
  Lines       15188    15250      +62     
==========================================
+ Hits         9138     9187      +49     
- Misses       5421     5432      +11     
- Partials      629      631       +2

client/keys/parse.go Outdated Show resolved Hide resolved
client/keys/parse.go Outdated Show resolved Hide resolved
client/keys/parse.go Outdated Show resolved Hide resolved
client/keys/parse.go Outdated Show resolved Hide resolved
@alessio alessio requested a review from fedekunze April 29, 2019 14:21
@alessio alessio changed the title [preliminary review] gaiakeyutil -> gaiacli keys parse gaiakeyutil -> gaiacli keys parse Apr 29, 2019
@alessio alessio changed the title gaiakeyutil -> gaiacli keys parse R4R: gaiakeyutil -> gaiacli keys parse Apr 29, 2019
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although do we want to add a test case for the CLI and update the docs too ?

@alessio
Copy link
Contributor Author

alessio commented Apr 30, 2019

@fedekunze this small utility hadn't made it into docs back then - I'm planning to incorporate gaiareplay into gaiacli as well, which too is undocumented. I'll add all relevant docs in an ensuing PR if you don't mind @fedekunze

@alessio alessio requested a review from fedekunze April 30, 2019 13:09
client/keys/parse.go Outdated Show resolved Hide resolved
client/keys/parse.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK.

client/keys/parse.go Show resolved Hide resolved
@alessio alessio requested a review from alexanderbez May 2, 2019 00:11
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK.

@alexanderbez alexanderbez merged commit 4e70a37 into master May 2, 2019
@alexanderbez alexanderbez deleted the alessio/remove-gaiakeyutil branch May 2, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants