Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 withdraw all for distribution rewards #3476

Closed
rigelrozanski opened this issue Feb 1, 2019 · 3 comments
Closed

F1 withdraw all for distribution rewards #3476

rigelrozanski opened this issue Feb 1, 2019 · 3 comments

Comments

@rigelrozanski
Copy link
Contributor

Currently within x/distribution/client/cli/tx.go : GetCmdWithdrawRewards a delegator can only withdraw from one validator at a time... infact there isn't an early check to ensure that the validator input is provided - it will just error when it tries to parse the validator from "".

The old distribution CLI had a "withdraw all path" which was the default and didn't require a validator address - we should reimplement this for F1 as well as a "withdraw all as well as my commission" for validators.

This can be implemented as either multi-transaction (of the existing message types) or a new "withdraw all" msg types within distribution.

CC @cwgoes @alessio

@rigelrozanski rigelrozanski added this to the v0.31.0 (Launch RC) milestone Feb 1, 2019
@rigelrozanski rigelrozanski changed the title withdraw all for distribution rewards F1 withdraw all for distribution rewards Feb 1, 2019
@cwgoes
Copy link
Contributor

cwgoes commented Feb 2, 2019

Hmm, I think this should instead be done as a multi-msg transaction, why put extra iteration in the (costly) state machine when the transaction builder could do it themselves?

All in favor of having that be automated via CLI.

@rigelrozanski
Copy link
Contributor Author

sry yeah by multi-transaction I meant multi msg ++

@alessio
Copy link
Contributor

alessio commented Feb 2, 2019

I've implemented as a multi msg TX in my pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants