-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibc: need blockID to verify commit #34
Comments
we don't really need to verify the the partsheader, so block hash is enough - just can't use tendermint/types.VerifyCommit ... use light-client https://github.com/tendermint/basecoin/issues/38 |
liamsi
pushed a commit
to liamsi/cosmos-sdk
that referenced
this issue
Jun 26, 2018
Removed all cli as it goes into cosmos-sdk
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this issue
Apr 19, 2021
faddat
referenced
this issue
in notional-labs/cosmos-sdk
Dec 3, 2021
* Try to fix the mutex contention * downstream copy my pr for logs in initgenesis * CacheKVStore linear factor improvements * Reset map size (extremely important for unfortunate access patterns) * Comment out module.go test for init genesis, assume logger lines are safe
faddat
referenced
this issue
in notional-labs/cosmos-sdk
Dec 18, 2021
* Try to fix the mutex contention * downstream copy my pr for logs in initgenesis * CacheKVStore linear factor improvements * Reset map size (extremely important for unfortunate access patterns) * Comment out module.go test for init genesis, assume logger lines are safe
Raumo0
pushed a commit
to mapofzones/cosmos-sdk
that referenced
this issue
Feb 13, 2022
…smos#34) * Refactor delaying of staking updates * Remove print statements * Remove turning off of update delays * Add comments * Review feedback * Revert validator key as func back to var * Split dkg and consensus validator updates * Bug fix on dkg validator updates * Bump consensus to v0.6.0 * Modify comments * Modify comments * Modify comment
Thunnini
referenced
this issue
in Thunnini/cosmos-sdk
Feb 28, 2022
* Try to fix the mutex contention * downstream copy my pr for logs in initgenesis * CacheKVStore linear factor improvements * Reset map size (extremely important for unfortunate access patterns) * Comment out module.go test for init genesis, assume logger lines are safe
DongLieu
pushed a commit
to likesToEatFish/cosmos-sdk
that referenced
this issue
Sep 20, 2024
refactor!: v0.45.16-ics-onomy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On IBCUpdateChainTx, We need to check the commit matches the header, but a commit is for a blockID, which we can't derive from the header alone. So either we:
Fetch the LastBlockID from the next block and include it with the Header and Commit in the IBCUpdateChainTx. We actually only need the PartSetHeader from the BlockID, since we can compute the Hash from the Header. So to prepare such a tx we would fetch the header from block H and the LastBlockID and LastCommit from block H+1.
Write a new VerifyCommit that returns the blockID with +2/3 of the power. This would leave IBCUpdateChainTx unchanged. Currently, VerifyCommit takes a BlockID as argument and ignores votes for other IDs. We could have an alternative, VerifyCommitReturnBlockID that instead returns the BlockID that has +2/3, if there is one.
The text was updated successfully, but these errors were encountered: