Folder reorganize: Add tests/ to scripts/ ? #138
Comments
|
Right now |
|
I like |
|
Renamed this in |
alexanderbez
added a commit
that referenced
this issue
Apr 5, 2022
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.2.1 to 1.4.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.2.1...v1.4.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
mattverse
referenced
this issue
in mattverse/cosmos-sdk
Apr 20, 2022
fix: make proto-check-breaking work for forks
rootulp
referenced
this issue
in rootulp/cosmos-sdk
Oct 21, 2022
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * updates tests to be able to set orch/eth address when creating validators * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * adds validator check tests * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * remove unnecessary eth address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
related: https://github.com/tendermint/basecoin/issues/121
We should reconsider how this repo is organized a little bit, I could see a case possibly for merging scrips and tests into one folder for all the bash stuff (maybe).
One core confusing part is I think that there needs to be a more parsed out
commonbash script section within the tests - but these might apply to more than just tests! - could maybe apply to some of the non-test scripts too? If we are going to integrate in shelldown testing of the docs, We already need some new common scripts that don't really belong in the existingcommon.shfile.The text was updated successfully, but these errors were encountered: