Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add very clear warning when basecli has not been inited #137

Closed
ethanfrey opened this issue Jun 23, 2017 · 1 comment
Closed

Add very clear warning when basecli has not been inited #137

ethanfrey opened this issue Jun 23, 2017 · 1 comment

Comments

@ethanfrey
Copy link
Contributor

The current panic is less than illuminating. We should add a general check.

I think I am the only one that recognizes the cause of the panic, and never bothered to add an error message.

# basecli-hermes query account $ME
panic: Panicked on a Sanity Check: Expected fully formed listening address, including the tcp:// or unix:// prefix, given
goroutine 1 [running]:
panic(0xb0f7a0, 0xc4200f43f0)
        /usr/local/go/src/runtime/panic.go:500 +0x1a1
github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/common.PanicSanity(0xb0f7a0, 0xc4200f43d0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/common/errors.go:26 +0xe0
github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/lib/client.makeHTTPDialer(0x0, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/lib/client/http_client.go:30 +0x2d7
github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/lib/client.makeHTTPClient(0x0, 0x0, 0x0, 0x0, 0x0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/lib/client/http_client.go:44 +0x39
github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/lib/client.NewJSONRPCClient(0x0, 0x0, 0xb0f7a0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/lib/client/http_client.go:61 +0x39
github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/client.NewHTTP(0x0, 0x0, 0xc20e6f, 0xa, 0x0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tendermint/rpc/client/httpclient.go:34 +0x4d
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.GetNode(0x0, 0x20)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/common.go:41 +0x63
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/proofs.GetAndParseAppProof(0xc42000e180, 0x1b, 0x20, 0xae0400, 0xc420022290, 0xc42000e180, 0x7, 0x20, 0x0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/proofs/get.go:29 +0x42
github.com/tendermint/basecoin/cmd/basecli/commands.doAccountQuery(0x1152a40, 0xc4200d1ce0, 0x1, 0x3, 0x0, 0x0)
        /go/src/github.com/tendermint/basecoin/cmd/basecli/commands/query.go:29 +0x1a7
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).execute(0x1152a40, 0xc42048be80, 0x3, 0x4, 0x1152a40, 0xc42048be80)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:621 +0x247
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1158440, 0x481ae2, 0xc4204f7d40, 0x2)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:700 +0x367
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).Execute(0x1158440, 0x24, 0xc4204f7cca)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:659 +0x2b
github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/cli.Executor.Execute(0x1158440, 0xdb66d0, 0x2, 0xc4204f7cf0)
        /go/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/cli/setup.go:97 +0x66
main.main()
        /go/src/github.com/tendermint/basecoin/cmd/basecli/main.go:60 +0x32a
@ethanfrey ethanfrey mentioned this issue Jun 26, 2017
Merged
@ethanfrey
Copy link
Contributor Author

Fixed with #142

faddat referenced this issue in notional-labs/cosmos-sdk Mar 21, 2022
@p0mvn @faddat
backport feat: Modify grpc gateway to be concurrent (cosmos#11234) fr…
2cc667d 
…om cosmos-sdk (#137)
alexanderbez pushed a commit that referenced this issue Apr 5, 2022
@p0mvn
backport feat: Modify grpc gateway to be concurrent (#11234) from cos…
87988f9 
…mos-sdk (#137)
rootulp referenced this issue in rootulp/cosmos-sdk Oct 21, 2022
@rach-id
feat: Adds validator qgb checks (#137)
99fcf70 
* first pass on tests fixes

* fixes the rest of unit tests

* remove unnecessary comments

* uses default eth address when starting sim network

* cosmetics

* comments failing test

* comments failing test

* adds orchestrator/ethereum address checks for validators when creating and editing

* uses correct error codes for eth/orch address errors

* uncomments test and fixes it from commit 434b308

* adds zero eth address check when creating/updating validator

* attempts to fix duplicate eth address in sim network

* revert squashed changes

* uses unwrapped context for msg_server orch/eth validation

* increase DefaultGenTxGas to accomodate new qgb validator changes

* scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it

* fix eth address creation from orch address in operations

* increase DefaultGenTxGas

* increase DefaultGenTxGas

* simpler way of creating an eth address from orch address in operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethanfrey