-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal messages are missing cosmos_proto.implements_interface
option
#12640
Comments
@aaronc I think you were involved in a few issues/PRs around |
This was referenced Jul 20, 2022
mergify bot
pushed a commit
that referenced
this issue
Jul 20, 2022
It seems that we're missing the `cosmos_proto.implements_interface` on many proposal messages/structs this is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement `Content`: ``` option (cosmos_proto.implements_interface) = "cosmos.gov.v1beta1.Content" ``` Would this be a breaking change? Happy to improve/amend this so it's mergeable. related issue: #12640
closed by #12639 |
mergify bot
pushed a commit
that referenced
this issue
Jul 21, 2022
It seems that we're missing the `cosmos_proto.implements_interface` on many proposal messages/structs this is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement `Content`: ``` option (cosmos_proto.implements_interface) = "cosmos.gov.v1beta1.Content" ``` Would this be a breaking change? Happy to improve/amend this so it's mergeable. related issue: #12640 (cherry picked from commit 64674ba)
amaury1093
pushed a commit
that referenced
this issue
Jul 21, 2022
It seems that we're missing the `cosmos_proto.implements_interface` on many proposal messages/structs this is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement `Content`: ``` option (cosmos_proto.implements_interface) = "cosmos.gov.v1beta1.Content" ``` Would this be a breaking change? Happy to improve/amend this so it's mergeable. related issue: #12640 (cherry picked from commit 64674ba) Co-authored-by: Dan Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
in ADR 019 it states
We're doing codegen, and we're missing many of the
cosmos_proto.implements_interface
: cosmology-tech/telescope#118 (comment)If we can add these into the protos, it would help the codegen flow to make client-side serialization better.
I've drafted a PR here: #12639
For Admin Use
The text was updated successfully, but these errors were encountered: