Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basecli panic on validator hash check #126

Closed
ebuchman opened this issue Jun 21, 2017 · 2 comments
Closed

basecli panic on validator hash check #126

ebuchman opened this issue Jun 21, 2017 · 2 comments

Comments

@ebuchman
Copy link
Member

If I hit enter without typing a letter.

ethanbuchman:basecoin$ basecli init --chain-id=test_chain_id --node=tcp://localhost:46657
Loading validator set from tendermint rpc...

Important: if this is incorrect, all interaction with the chain will be insecure!
  Given validator hash valid: EB168E17E45BAEB194D4C79067FFECF345C64DE6
Is this valid (y/n)?

panic: unexpected newline

goroutine 1 [running]:
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.askForConfirmation(0xc4200ed9f8)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:228 +0x234
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.validateHash(0xc420071ba0, 0xc420098e80, 0xc4201407b0, 0x0, 0x0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:192 +0x1e3
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.initSeed(0x1c4c1a0, 0x0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:175 +0x434
github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands.runInit(0x1c4c1a0, 0xc420156460, 0x0, 0x2, 0x0, 0x0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/light-client/commands/init.go:71 +0xd1
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).execute(0x1c4c1a0, 0xc420156420, 0x2, 0x2, 0x1c4c1a0, 0xc420156420)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:656 +0x3f8
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1c4dd40, 0x2, 0x2, 0xc420156380)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:735 +0x339
github.com/tendermint/basecoin/vendor/github.com/spf13/cobra.(*Command).Execute(0x1c4dd40, 0xc4201546c0, 0x16)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/spf13/cobra/command.go:694 +0x2b
github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/cli.Executor.Execute(0x1c4dd40, 0x18c1208, 0x2, 0xc4201562e0)
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/vendor/github.com/tendermint/tmlibs/cli/setup.go:97 +0x4e
main.main()
        /Users/ethanbuchman/programming/goApps/src/github.com/tendermint/basecoin/cmd/basecli/main.go:57 +0x340
ethanbuchman:basecoin$ 

@ethanfrey
Copy link
Contributor

Fixed on light-client:develop as of e2aeaeb

Need to update deps.

@ethanfrey
Copy link
Contributor

Fixed as of #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants