Report errors in Close() defer functions

[robert-zaremba]

Description

Very often we ignore errors, or omit them in a defer functions, eg:

defer file.Close()

Proposal

Create a wrapper function:

func logError(logger, f func() error) {
    if err := f(); err != nil {
        logger.Error(err)
    }
}
...

defer logError(ctx.Logger(), file.Close)

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

ACK. Would be in favor of calling it LogDeferred

[leoflalv]

Hi, I am new to this repo and would like to take this task, can I? I just have a question, should it be part of this task to add the new helper in the necessary places?

[robert-zaremba]

@leoflalv sure. I propose you to firstly create a small PR by updating only one module. Maybe x/bank or /client.