went back to inmem sink being the default

cosmos · Dec 9, 2023 · 4905617 · 4905617
1 parent 150a5dc
commit 4905617
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/server/config/config.go b/server/config/config.go
@@ -234,7 +234,6 @@ func DefaultConfig() *Config {
 		Telemetry: telemetry.Config{
 			Enabled:      false,
 			GlobalLabels: [][]string{},
-			MetricsSink:  telemetry.MetricSinkInMem,
 		},
 		API: APIConfig{
 			Enable:             false,

diff --git a/telemetry/metrics.go b/telemetry/metrics.go
@@ -115,7 +115,11 @@ func New(cfg Config) (_ *Metrics, rerr error) {
 		err  error
 	)
 	switch cfg.MetricsSink {
-	case MetricSinkInMem:
+	case MetricSinkStatsd:
+		sink, err = metrics.NewStatsdSink(cfg.StatsdAddr)
+	case MetricSinkDogsStatsd:
+		sink, err = datadog.NewDogStatsdSink(cfg.StatsdAddr, cfg.DatadogHostname)
+	default:
 		memSink := metrics.NewInmemSink(10*time.Second, time.Minute)
 		sink = memSink
 		inMemSig := metrics.DefaultInmemSignal(memSink)
@@ -124,12 +128,6 @@ func New(cfg Config) (_ *Metrics, rerr error) {
 				inMemSig.Stop()
 			}
 		}()
-	case MetricSinkStatsd:
-		sink, err = metrics.NewStatsdSink(cfg.StatsdAddr)
-	case MetricSinkDogsStatsd:
-		sink, err = datadog.NewDogStatsdSink(cfg.StatsdAddr, cfg.DatadogHostname)
-	default:
-		sink = &metrics.BlackholeSink{}
 	}
 
 	if err != nil {