Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronc committed Sep 23, 2021
1 parent b3db697 commit 4853a24
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
8 changes: 0 additions & 8 deletions container/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,3 @@ func duplicateDefinitionError(typ reflect.Type, duplicateLoc Location, existingL
return errors.Errorf("duplicate provision of type %v by %s\n\talready provided by %s",
typ, duplicateLoc, existingLoc)
}

func dependencyCycleError(failingLocation Location, failingType reflect.Type, callStack []Location) error {
panic("TODO")
}

func cantResolveError(typ reflect.Type, resolveStack []resolveFrame) error {
panic("TODO")
}
7 changes: 0 additions & 7 deletions container/struct_args.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ import (
"github.com/pkg/errors"
)

// StructArgs is a type which can be embedded in another struct to alert the
// container that the fields of the struct are dependency inputs/outputs. That
// is, the container will not look to resolve a value with StructArgs embedded
// directly, but will instead use the struct's fields to resolve or populate
// dependencies. Types with embedded StructArgs can be used in both the input
// and output parameter positions.

// In can be embedded in another struct to inform the container that the
// fields of the struct should be treated as dependency inputs.
// This allows a struct to be used to specify dependencies rather than
Expand Down

0 comments on commit 4853a24

Please sign in to comment.