Skip to content

Commit

Permalink
refactor: add miss defer
Browse files Browse the repository at this point in the history
  • Loading branch information
hoank101 committed Jun 9, 2024
1 parent ca14b28 commit 037856e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions store/v2/commitment/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ func (c *CommitStore) LoadVersion(targetVersion uint64) error {
}
if targetVersion < latestVersion {
batch := c.db.NewBatch()
defer batch.Close() // Ensure the batch is closed on function exit
for version := latestVersion; version > targetVersion; version-- {
cInfoKey := []byte(fmt.Sprintf(commitInfoKeyFmt, version))
if err := batch.Delete(cInfoKey); err != nil {
Expand Down Expand Up @@ -186,6 +187,7 @@ func (c *CommitStore) flushCommitInfo(version uint64, cInfo *proof.CommitInfo) e
}

batch := c.db.NewBatch()
defer batch.Close() // Ensure the batch is closed on function exit.
cInfoKey := []byte(fmt.Sprintf(commitInfoKeyFmt, version))
value, err := cInfo.Marshal()
if err != nil {
Expand Down Expand Up @@ -306,6 +308,7 @@ func (c *CommitStore) Get(storeKey []byte, version uint64, key []byte) ([]byte,
func (c *CommitStore) Prune(version uint64) (ferr error) {
// prune the metadata
batch := c.db.NewBatch()
defer batch.Close() // Ensure the batch is closed on function exit.
for v := version; v > 0; v-- {
cInfoKey := []byte(fmt.Sprintf(commitInfoKeyFmt, v))
if exist, _ := c.db.Has(cInfoKey); !exist {
Expand Down
1 change: 0 additions & 1 deletion store/v2/migration/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ func (m *Manager) writeChangeset() error {
if err != nil {
return err
}
batch.Close()
}

return nil
Expand Down

0 comments on commit 037856e

Please sign in to comment.