Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to latest from main #51

Merged
merged 4 commits into from
Sep 26, 2023
Merged

update docs to latest from main #51

merged 4 commits into from
Sep 26, 2023

Conversation

tac0turtle
Copy link
Member

No description provided.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff makes my tab crash.
Blind ACK. I assume it's run from the script?

This commits looks good: 538c5a1

@tac0turtle
Copy link
Member Author

Blind ACK. I assume it's run from the script?

yes script changes


---

# Glossary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this file disappeared?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably because its not on the sdk-repo, its a new piece

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont merge yet im going through each piece

Copy link
Member Author

@tac0turtle tac0turtle Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no its not in the main repo either, seems it was removed outright. looks useful

Copy link
Member

@julienrbrt julienrbrt Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the script copies the learn, develop and build category from the repo.
In my opinion, the glossary is useful for each version and common and does not need to be versioned.
This file could be moved out of develop, build or learn category and be common to all versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i wrote the glossary and only put it in the docs repo so this is something that could be excluded from the whole duplication of docs

Copy link
Member

@julienrbrt julienrbrt Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the file should just be moved the docs folder directly, https://github.com/cosmos/cosmos-sdk-docs/tree/main/docs, so need of subfolder. It won't be removed after the script is run at this place.
This may be relevant: https://docusaurus.io/docs/docs-multi-instance, so the glossary (and possibly tutorials?) aren't versioned but common to all versions.

from: ["/main/modules/capability", "/main/ecosystem"],
to: "/main/build/modules/",
},
// {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needed to be commented out to build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cosmos/cosmos-sdk#17881 will fix this

@tac0turtle tac0turtle merged commit b10dff5 into main Sep 26, 2023
1 check passed
@tac0turtle tac0turtle deleted the marko/update branch September 26, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants