-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs to latest from main #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff makes my tab crash.
Blind ACK. I assume it's run from the script?
This commits looks good: 538c5a1
yes script changes |
docs/develop/glossary.md
Outdated
|
||
--- | ||
|
||
# Glossary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this file disappeared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably because its not on the sdk-repo, its a new piece
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont merge yet im going through each piece
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no its not in the main repo either, seems it was removed outright. looks useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the script copies the learn, develop and build category from the repo.
In my opinion, the glossary is useful for each version and common and does not need to be versioned.
This file could be moved out of develop, build or learn category and be common to all versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i wrote the glossary and only put it in the docs repo so this is something that could be excluded from the whole duplication of docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the file should just be moved the docs
folder directly, https://github.com/cosmos/cosmos-sdk-docs/tree/main/docs, so need of subfolder. It won't be removed after the script is run at this place.
This may be relevant: https://docusaurus.io/docs/docs-multi-instance, so the glossary (and possibly tutorials?) aren't versioned but common to all versions.
from: ["/main/modules/capability", "/main/ecosystem"], | ||
to: "/main/build/modules/", | ||
}, | ||
// { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needed to be commented out to build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosmos/cosmos-sdk#17881 will fix this
No description provided.