bech32: Add DecodeUnsafe for bypassing checksum validation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Sep 15, 2021
| func Decode(bech string) (string, []byte, error) { | ||
| // The maximum allowed length for a bech32 string is 90. | ||
| if len(bech) > 90 { | ||
| func Decode(bech string, limit int) (string, []byte, error) { |
There was a problem hiding this comment.
This change is the same as the enigma change which the SDK already uses IIRC, so not API breaking for the cosmos SDK
|
Hey, thanks for opening this PR. IN the future lets get reviews prior to merging. Seems tests arent passing now |
|
@marbar3778 I'm sorry for merging PR before getting review. I thought that ValarDragon's comment meant LGTM, but he had forgotten approving PR. I checked whether all unit tests pass, but missed linting things. (gofmt) There is no functional issue. @ValarDragon Thank you for reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cosmos/cosmos-sdk#10025.