Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Renovate code for newer dep versions. #2

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Conversation

s3rj1k
Copy link
Contributor

@s3rj1k s3rj1k commented Jul 2, 2024

Renovate some code-deps in preparation for v3 engine addition.
(Planning to keep v2 for reference tests)

@fzipi
Copy link
Member

fzipi commented Jul 2, 2024

The perfect PR will be to setup the ci/cd that proves this works 😎

@s3rj1k
Copy link
Contributor Author

s3rj1k commented Jul 2, 2024

perfect PR

small steps preferably, works for me locally, I am getting some CSV using mostly stock coraza.conf-recommended

Running on 12th Gen Intel(R) Core(TM) i5-1240P with 16 cores and 16gb mem
Workers: 16
Count: 10000
Running tests for "coraza_v2" engine
Opening  simple_get.yaml
Preparing test case "Simple GET" on "coraza_v2"
case "Simple GET":
Took 5 seconds, 33us per request.
Phase 1: 101.013us
Phase 2: 61.862us
Phase 3: 15.571us
Phase 4: 9.748us
Phase 5: 5.196us
-----
Opening  simple_json.yaml
Preparing test case "Simple JSON" on "coraza_v2"
case "Simple JSON":
Took 13 seconds, 82us per request.
Phase 1: 183.324us
Phase 2: 760.692us
Phase 3: 16.412us
Phase 4: 12.574us
Phase 5: 5.347us
-----
Opening  simple_urlencoded.yaml
Preparing test case "Simple URlencoded" on "coraza_v2"
case "Simple URlencoded":
Took 6 seconds, 39us per request.
Phase 1: 151.918us
Phase 2: 103.456us
Phase 3: 17.315us
Phase 4: 4.479us
Phase 5: 5.735us
-----
Opening  simple_xml.yaml
Preparing test case "Simple XML" on "coraza_v2"
case "Simple XML":
Took 10 seconds, 62us per request.
Phase 1: 210.316us
Phase 2: 353.518us
Phase 3: 25.136us
Phase 4: 6.919us
Phase 5: 5.921us
-----
Running tests for "modsec_v3" engine
Opening  simple_get.yaml
Preparing test case "Simple GET" on "modsec_v3"
case "Simple GET":
Took 1 seconds, 7us per request.
Phase 1: 17.566us
Phase 2: 32.638us
Phase 3: 2.721us
Phase 4: 0.945us
Phase 5: 28.344us
-----
Opening  simple_json.yaml
Preparing test case "Simple JSON" on "modsec_v3"
case "Simple JSON":
Took 2 seconds, 15us per request.
Phase 1: 38.152us
Phase 2: 111.685us
Phase 3: 3.346us
Phase 4: 1.151us
Phase 5: 41.801us
-----
Opening  simple_urlencoded.yaml
Preparing test case "Simple URlencoded" on "modsec_v3"
case "Simple URlencoded":
Took 1 seconds, 9us per request.
Phase 1: 27.600us
Phase 2: 46.045us
Phase 3: 2.990us
Phase 4: 1.002us
Phase 5: 31.260us
-----
Opening  simple_xml.yaml
Preparing test case "Simple XML" on "modsec_v3"
case "Simple XML":
Took 1 seconds, 10us per request.
Phase 1: 32.680us
Phase 2: 51.777us
Phase 3: 2.984us
Phase 4: 1.058us
Phase 5: 33.835us
-----
Writing CSV
Engine,Case,p1,p2,p3,p4,p5,Overall
coraza_v2,Simple GET,101.013,61.862,15.571,9.748,5.196,5376304.152
coraza_v2,Simple JSON,183.324,760.692,16.412,12.574,5.347,13229286.154
coraza_v2,Simple URlencoded,151.918,103.456,17.315,4.479,5.735,6291965.936
coraza_v2,Simple XML,210.316,353.518,25.136,6.919,5.921,10026514.846
modsec_v3,Simple GET,17.566,32.638,2.721,0.945,28.344,1149271.808
modsec_v3,Simple JSON,38.152,111.685,3.346,1.151,41.801,2476563.238
modsec_v3,Simple URlencoded,27.600,46.045,2.990,1.002,31.260,1444133.768
modsec_v3,Simple XML,32.680,51.777,2.984,1.058,33.835,1603684.443

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm

@fzipi fzipi merged commit fbe72cf into corazawaf:master Jul 2, 2024
@fzipi
Copy link
Member

fzipi commented Jul 2, 2024

Looking forward to your next contribution!

@s3rj1k s3rj1k deleted the renovate branch July 2, 2024 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants