Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config option to control whether Coq buttons are displayed #904

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Durbatuluk1701
Copy link
Contributor

I personally don't like many buttons in the Editor Actions tab menu, so I think it would be nice to be able to disable them from appearing.
When vscoq.general.display-buttons == true (which it is by default) the buttons will be visible:
image
Otherwise, the buttons won't appear.

I could not really think of a good pre-existing setting scope to put them in, so I created one called general, but if anyone has renaming thoughts or a better place to put it just feel free.

client/package.json Outdated Show resolved Hide resolved
@rtetley rtetley changed the title Add config option to control whether Coq buttons are displayed feat: add config option to control whether Coq buttons are displayed Sep 13, 2024
@Durbatuluk1701
Copy link
Contributor Author

@rtetley Can I get some guidance on why this CI is failing?

@rtetley
Copy link
Collaborator

rtetley commented Sep 13, 2024

Just looks like a sporadic network error failure.

@rtetley rtetley self-requested a review September 13, 2024 13:38
Copy link
Collaborator

@rtetley rtetley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@rtetley rtetley merged commit 3a1d581 into coq:main Sep 13, 2024
24 checks passed
@Durbatuluk1701 Durbatuluk1701 deleted the button-toggle-option branch September 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants