fix: off by one error in Hover #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Durbatuluk1701
commented
Sep 12, 2024
| Some word | ||
| with Not_found -> | ||
| with _ -> |
There was a problem hiding this comment.
Not sure if this is idiomatic in Ocaml, but I noticed when looking at #731 that if we attempt to hover on a non-ascii character it could cause a crash due to String.sub raising Invalid_argument
There was a problem hiding this comment.
More generally I wonder (I am not really experienced in Ocaml) what the proper way for doing something akin to Regex in UTF would be to help eventually solve 731.
There was a problem hiding this comment.
Not sure how to handle this. Maybe @gares has pointers ?
rtetley
changed the title
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the string we are hovered on to be the start of the word index to end of word (does not include any period at the end)