-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Add prettier formatter #849
Conversation
}, | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"editor.formatOnSave": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question beyond this PR, should these settings be tracked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't know. My feeling is probably not ?
The CI failures are due to the yarn.nix files not being updated. Could you run the |
Having some 🤷 conflicts, if you could check them @rtetley pls. |
There was a little bug in |
I don't think this is necessary but since it's already tracked...
The CI failures are still due to the yarn.nix files. No need to rebase this time though :-) |
Thanks ! |
Adding a base setup to have a formatter for the main extension files.
It is not formatting the goal view nor search ui because they have separate config files, which I think can be handled differently (vite setup).
Fixed some typos.