[outline] list alien, named, symbols #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Jul 16, 2024
|
I did nothing to fill the other fields of the outline entry. I tested and it jumps to the right place, but the popup shows "foo (null)" that is a bit sad. I'd rather like "foo (external)". We could also equip Coq with a more precise metadata and display that. |
|
FTR, this PR also displays Ltac symbols (did not test with Ltac2 symbols though). |
SkySkimmer
reviewed
Jul 23, 2024
| | Vernacexpr.VernacStartTheoremProof (kind, _) -> Some (TheoremKind kind) | ||
| | Vernacexpr.VernacDefinition ((_, def), _, _) -> Some (DefinitionType def) | ||
| | _ -> None | ||
| | Vernacexpr.VernacStartTheoremProof (kind, _) -> Some (TheoremKind kind), "theroem" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coq has a framework to add vernacular commands and give their classification. The classification can carry names.
This PR displays "named side effects" in the outline.
In the screenshots we see commands defined in Elpi.