Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coq] Adapt to coq/coq#19187 #783

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[coq] Adapt to coq/coq#19187 #783

merged 1 commit into from
Jun 10, 2024

Conversation

ejgallego
Copy link
Member

No description provided.

@ejgallego ejgallego mentioned this pull request Jun 8, 2024
Merged
gares
gares previously requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@gares gares left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use optcomp, that is put the change in a [%%if...] block.

@SkySkimmer SkySkimmer marked this pull request as ready for review June 10, 2024 11:59
@SkySkimmer SkySkimmer requested a review from gares June 10, 2024 12:01
@SkySkimmer SkySkimmer force-pushed the vernacstate_remove_pcoq branch from e79f822 to 88e0849 Compare June 10, 2024 13:31
@SkySkimmer SkySkimmer merged commit bab9457 into coq:main Jun 10, 2024
18 of 22 checks passed
@ejgallego ejgallego deleted the vernacstate_remove_pcoq branch June 10, 2024 13:34
@ejgallego
Copy link
Member Author

Thanks @SkySkimmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkySkimmer SkySkimmer SkySkimmer left review comments

@gares gares Awaiting requested review from gares

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejgallego @gares @SkySkimmer