Formatting proof view #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working "responsive" goal view. The goals break along the break hints when the window is resized. Done with a naive "break" selection algorithm.
Heuristic which sorts breaks with respect to their box hierarchy.
Trying to find a better algorithm for break selection
Changed the philosophy: rework the received data into something more workable for my goal view. I use css selectors to select the boxes and breaks which leads to a break algo akin to Format. Later down the line I can re-work the break algo.
tomtomjhj
reviewed
Jun 7, 2024
| ); | ||
| case PpMode.hvBox: | ||
| if(lineBreak) { | ||
| <span id={id}> |
There was a problem hiding this comment.
Good catch ! I think handling hvBoxes correctly stilll needs a bit of work anyways !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749