Improve flake.nix, add compatibility with pkgs.vscode extensions field #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new packages.${system}.vscoq-client.[extension, vsix_archive] derivations
- `extension` derivation builds the out folder in such a way that this derivation can be passed to vscode in Nix to automatically load it as an extension
- `vsix_archive` derivation builds the vsix and places it in $out/share/vscode/extensions
- Add formatter
- Add `nix fmt` in CI before yarn.nix check
- Use attribute sets instead of property accesses for less boilerplate
|
Not sure why the one CI check that doesn't even touch Nix failed but I'll look at it |
|
Thanks for your contribution ! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two new outputs, packages.${system}.vscoq-client.[extension, vsix_archive].
The
extensionderivation builds the out folder in such a way that this derivation can be passed to vscode in Nix to automatically load it as an extension. Specifically, the source (including webpack results in the dist folder) are placed in $out/share/vscode/extensions/maximedenes.vscoq.This is very useful for NixOS users or even people who use a shell.nix to configure their development environment.
The
vsix_archivederivation builds the .vsix and places it in $out/share/vscode/extensions.This PR also adds the lightweight Alejandra formatter output in flake.nix, which is automatically picked up by nix when running the command
nix fmt. This is useful for two reasons:nix fmtin CI, which avoids failing CI when whitespace or other insignificant changes occur in the generated yarn.nix files.