Better highlights #744
Merged
Better highlights #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtetley
force-pushed
the
better-highlights
branch
3 times, most recently
from
584904a to
173ad49
Compare
|
This is preliminary work. It solves the performance issues for good (making them on par with VsCoq 1 on the linked example from #657. It also creates better distinctions between executed, executing and "prepared" (i.e. the range the user has asked after an interpret to point). I am not sure how well it works with delegation. |
gares
reviewed
Mar 28, 2024
| @@ -291,7 +318,8 @@ let init init_vs ~opts uri ~text observe_id = | |||
| let init_vs = Vernacstate.freeze_full_state () in | |||
| let document = Document.create_document init_vs.Vernacstate.synterp text in | |||
| let execution_state, feedback = ExecutionManager.init init_vs in | |||
| let st = { uri; opts; init_vs; document; execution_state; observe_id } in | |||
| let overview = { processing = []; processed = []; prepared = []} in | |||
There was a problem hiding this comment.
nitpick: define an empty_overview since you do this twice
gares
reviewed
Mar 28, 2024
Comment on lines
+236
to
+245
| if Position.compare r1.Range.start r.Range.start == 0 && | ||
| Position.compare r1.Range.end_ r.Range.end_ == 0 |
There was a problem hiding this comment.
this looks like Position.equal (if we derived one)
gares
approved these changes
Mar 28, 2024
rtetley
force-pushed
the
better-highlights
branch
2 times, most recently
from
fd77091 to
02fb4bf
Compare
The highlights will now be computed on the go. This improves considerably improves performance and will enable easily building more imformative highlights (processed, parsed, etc...)
Some work to allow getting the decorations only until a sentence, which allows for displaying navigation in manual mode.
We switch back the exec_overview in the document manager. Additionally we use the Execute events to track which sentence is currently executing or processed.
When a user triggers a interpret to point, it will show up as a prepared range until it is executing or executed.
rtetley
force-pushed
the
better-highlights
branch
from
02fb4bf to
1870fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for making faster and better highlights
Adresses #743 for manual mode, need to think it through for continuous mode.
Closes #657
Closes #642