-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt w.r.t. coq/coq#18652. #722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks 8.19 and 8.18.
We use ppx_optcomp that gives you ifdefs at the top level. There are a few examples around already, please follow that style
bcfd2bd
to
83e4a89
Compare
Fixed. |
@rtetley we should not fail fast in the matrix. Here coq master does not include the change yet, but we still want to test 8.18 and 8.19 |
Also the opamfile ditches .dev, so we test coq 8.19 twice (the dev job downgrades it) |
We should add a ... | = "dev" in the expression |
Sorry for pushing here ci changes, but this is the first PR after the ppx_optcomp change, hence we need to streamline the process |
Opam ci still broken. We need to pin coq to the version, otherwise the next command upgrades it to .dev |
looks finally ok, the only jobs failing are the ones about coq master, since these are tested by Coq ci (against the PR requiring this change). The jobs about stable versions are green. @rtetley the CI changes can be pushed to master, IMO. Dunno if we want the dev jobs to be in allowed-failure, or not. It could make the reading of this CI much clearer for the coq dev submitting PRs. |
There are unrelated changes in this PR, maybe it should still be marked as a draft while the upstream Coq PR is not merged... |
No description provided.