Run vscoq.path as a shell command from the project directory
#715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an inconsistency between using `child_process.exec`, which runs the provided string as a shell command, and `vscode-languageclient`, which by default did not.
Also, `vscoqtop` is now always run from the directory of the project.
All that allows to use VsCoq for Coq projects built with dune, by putting the following to `.vscode/settings.json` (where `theories/Theory.v` is some Coq file):
```json
{
"vscoq.path": "dune coq top --toplevel vscoqtop theories/Theory.v --"
}
```
|
Merging as CI issues have been resolved in main. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency between using
child_process.exec, which runs the provided string as a shell command, andvscode-languageclient, which by default did not.Also,
vscoqtopis now always run from the directory of the project.All that allows to use VsCoq for Coq projects built with dune, by putting the following to
.vscode/settings.json(wheretheories/Theory.vis some Coq file):{ "vscoq.path": "dune coq top --toplevel vscoqtop theories/Theory.v --" }