Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent line length and move configs to pyproject.toml #4276

Merged

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Apr 15, 2023

Description

  • All our linters require different line length: line them all up at 119.
  • Move all supported configs to pyproject.toml with notable exceptions being (AFAIK) flake8 and pycodestyle
  • Move pytest & coverage configs to pyproject.toml

This max line length number was suggested to be aligned with Django's itself, but since then, they adopted black and moved to 88. I'm sticking to the initial suggestion of 119 for this pull request, we can see how some lines are no longer wrapping and IMO read better.

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Fix #2720 see issue for rationale.
Fix #4170

Closes #4270

@browniebroke browniebroke force-pushed the fix/consistent-line-length branch from a48faad to e29f3e0 Compare April 15, 2023 13:44
@browniebroke browniebroke merged commit 17fa459 into cookiecutter:master Apr 15, 2023
@browniebroke browniebroke deleted the fix/consistent-line-length branch April 15, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isort Compatiblity Black [Pre-Commit] Inconsistent line length (black vs 120)
1 participant