Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/append publish message after success #47

Merged
merged 1 commit into from
May 31, 2016
Merged

Feature/append publish message after success #47

merged 1 commit into from
May 31, 2016

Conversation

tomchentw
Copy link
Contributor

@tomchentw tomchentw commented May 30, 2016

Thanks for creating this package! It's not only awesome but also aligned with my best practices so I use it like at home. Just one more thing to add:

screen shot 2016-05-30 at 6 29 28 pm

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling faed42a on tomchentw:feature/append-publish-message-after-success into * on conventional-changelog:master*.

@stevemao
Copy link
Member

Looks good :) maybe a bit less verbose?

@tomchentw
Copy link
Contributor Author

@stevemao any suggested wording? I'm okay with any wording here. Just let me know so that I can change it.

@stevemao
Copy link
Member

I'd let @bcoe to make the call. But I'd probably just say "Run git push --follow-tags origin master; npm publish to publish."

@tomchentw
Copy link
Contributor Author

Updated for now.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4fdbfe3 on tomchentw:feature/append-publish-message-after-success into * on conventional-changelog:master*.

@bcoe
Copy link
Member

bcoe commented May 31, 2016

@tomchentw love it \o/

@bcoe bcoe merged commit e414ed7 into conventional-changelog:master May 31, 2016
@tomchentw tomchentw deleted the feature/append-publish-message-after-success branch June 1, 2016 00:37
@tomchentw
Copy link
Contributor Author

Thanks!

@tomchentw
Copy link
Contributor Author

Mind to release a new version on npm?

@bcoe
Copy link
Member

bcoe commented Jun 2, 2016

@tomchentw give this a shot:

npm i standard-version@next

thanks a ton for the contribution.

@tomchentw
Copy link
Contributor Author

@bcoe yeah it's working! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants