Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always pass version to changelog context #327

Merged
merged 1 commit into from
May 5, 2019
Merged

fix: always pass version to changelog context #327

merged 1 commit into from
May 5, 2019

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Apr 22, 2019

fixes: #326

@Djaler
Copy link
Contributor Author

Djaler commented Apr 23, 2019

This CI warnings are not due to me

@abcfy2
Copy link

abcfy2 commented Apr 25, 2019 •
edited
Loading

LGTM. Hope this PR could be merged.

@Djaler
Copy link
Contributor Author

Djaler commented Apr 25, 2019

@bcoe can you check this, please?

@bcoe bcoe merged commit 00e3381 into conventional-changelog:master May 5, 2019
@bcoe
Copy link
Member

bcoe commented May 5, 2019

@Djaler thank you for the patch 👍 I'm excited to get standard-version working better for non JavaScript projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No newVersion in changelog
3 participants
@Djaler @abcfy2 @bcoe