-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Are packageFiles
in .versionrc not bumped automatically?
#533
Comments
Hey @zaki-yama, thanks for the thorough write-up. Your observations seem correct – it looks like we're currently not merging the Your workaround is valid for now, just consider that without a |
@jbottigliero |
…iles` when no `bumpFiles` argument is specified (default). (#534) - Merges `packageFiles` with `defaults.bumpFiles` before merging in arguments when a `packageFile` argument is present. - Adds some simple "validation" to updaters and improves error messaging. - Adds a test case covering #533 closes #533
I'd like to ask you about the expected behavior.
Background
Now I have an
manifest.json
file underdist
directory.I'd like to sync versions in both
package.json
anddist/manifest.json
, so I addeddist/manifest.json
topackageFiles
in.versionrc.js
.Problem
I ran
standard-version
(with--dry-run
option), but it seems to bump up onlypackage.json
andpackage-lock.json
.Question
Is that the expected behavior?
In README,
I couldn't quite understand what "and be "bumped"" meant.
And default
packageFiles
are bumped because they are merged intobumpFiles
.Workaround
I can bump up by moving
dist/manifest.json
tobumpFiles
.But I had to contain
package.json
too (because it overwrote the default values).The text was updated successfully, but these errors were encountered: