Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration special case check-user-browser-vulns #1

Open
jmatsushita opened this issue Sep 18, 2017 · 2 comments
Open

Migration special case check-user-browser-vulns #1

jmatsushita opened this issue Sep 18, 2017 · 2 comments
Assignees

Comments

@jmatsushita
Copy link
Member

jmatsushita commented Sep 18, 2017

if (activities && key === 'activities/check-user-browser-vulns/index.md') {
return {
...file,
title: 'Check user browser vulnerabilities',
description: 'Outdated Java browser plugins',
contents: files['exercises/check_user_browser_vulns/browser_java_plugin.md'].contents
};

@jmatsushita jmatsushita self-assigned this Sep 18, 2017
@jmatsushita jmatsushita changed the title Deal with special case upstream Migration special case check-user-browser-vulns Sep 18, 2017
jmatsushita added a commit to contentascode/safetag-toolkit that referenced this issue Sep 18, 2017
jmatsushita added a commit that referenced this issue Sep 18, 2017
@jmatsushita
Copy link
Member Author

Hey @joncamfield

Should we keep this as a special case in the migration script?

This is where it builds: https://contentascode.github.io/safetag/@safetag/toolkit/activities/check-user-browser-vulns/

Note that Travis is very slow today so it make take a bit to show up.

Cheers,

Jun

@joncamfield
Copy link

joncamfield commented Sep 21, 2017

I have minimally addressed this by moving it to the normal structure, however, the exercise content needs review/revision, tracked in SAFETAG/SAFETAG#304 . Let me know if this removes this as a special case and I'll merge this and other commits upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants