Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming server #2070

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 18, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding streaming server support.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to cri-o/cri-o#7826

Does this PR introduce a user-facing change?

Added streaming server support.

Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 59.04762% with 43 lines in your changes missing coverage. Please review.

Project coverage is 48.36%. Comparing base (4e0f474) to head (944e709).
Report is 795 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2070       +/-   ##
===========================================
+ Coverage   37.53%   48.36%   +10.82%     
===========================================
  Files          15      131      +116     
  Lines        1268     4605     +3337     
  Branches      414      908      +494     
===========================================
+ Hits          476     2227     +1751     
- Misses        526     1783     +1257     
- Partials      266      595      +329     

@rphillips
Copy link
Collaborator

+1 to axum. Can we use a domain socket instead of a tcp socket?

@saschagrunert
Copy link
Member Author

+1 to axum. Can we use a domain socket instead of a tcp socket?

I have to check if Kubernetes supports that, but generally yes 👍

@saschagrunert
Copy link
Member Author

+1 to axum. Can we use a domain socket instead of a tcp socket?

No, it's currently not due to:
https://github.com/kubernetes/client-go/blob/1518fca9f06c6a73fc091535b8966c71704e657b/transport/websocket/roundtripper.go#L109

@saschagrunert saschagrunert force-pushed the streaming-server branch 10 times, most recently from b5702dc to 09e759e Compare March 21, 2024 08:32
@saschagrunert saschagrunert force-pushed the streaming-server branch 5 times, most recently from 1f275b3 to c0fc3cd Compare May 13, 2024 07:32
@saschagrunert saschagrunert force-pushed the streaming-server branch 10 times, most recently from 0235e05 to 940b614 Compare September 3, 2024 12:05
@saschagrunert
Copy link
Member Author

@kwilczynski @haircommander PTAL, shall we get this in?

@saschagrunert
Copy link
Member Author

Rebased

@saschagrunert
Copy link
Member Author

Rebased again.

@rphillips
Copy link
Collaborator

Did we get past the memory usage? I believe that blocked this feature before?

@saschagrunert
Copy link
Member Author

Did we get past the memory usage? I believe that blocked this feature before?

The memory usage will increase because the code added for the streaming server adds a static amount per instance.

-	export MAX_RSS_KB=9500 && \
+	export MAX_RSS_KB=12000 && \

We could make it a compilation feature but this would increase shipping complexity.

Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants