-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming server #2070
base: main
Are you sure you want to change the base?
Add streaming server #2070
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
===========================================
+ Coverage 37.53% 48.36% +10.82%
===========================================
Files 15 131 +116
Lines 1268 4605 +3337
Branches 414 908 +494
===========================================
+ Hits 476 2227 +1751
- Misses 526 1783 +1257
- Partials 266 595 +329 |
+1 to axum. Can we use a domain socket instead of a tcp socket? |
I have to check if Kubernetes supports that, but generally yes 👍 |
0ddb3d9
to
a875baa
Compare
a875baa
to
a116a19
Compare
a116a19
to
7cada3a
Compare
No, it's currently not due to: |
b5702dc
to
09e759e
Compare
a9bbf07
to
0e04aab
Compare
1f275b3
to
c0fc3cd
Compare
0235e05
to
940b614
Compare
@kwilczynski @haircommander PTAL, shall we get this in? |
940b614
to
2aa1443
Compare
Rebased |
2aa1443
to
55d9319
Compare
55d9319
to
d4d6f28
Compare
Rebased again. |
Did we get past the memory usage? I believe that blocked this feature before? |
The memory usage will increase because the code added for the streaming server adds a static amount per instance. - export MAX_RSS_KB=9500 && \
+ export MAX_RSS_KB=12000 && \ We could make it a compilation feature but this would increase shipping complexity. |
Signed-off-by: Sascha Grunert <[email protected]>
d4d6f28
to
944e709
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding streaming server support.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Refers to cri-o/cri-o#7826
Does this PR introduce a user-facing change?