Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.33] Fixes Listing tags in JFrog Artifactory may fail #5631

Conversation

TomSweeneyRedHat
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat commented Jul 16, 2024

Addresses the problem first described in containers/skopeo#2346

Also addresses: https://issues.redhat.com/browse/RHEL-40802 and
https://issues.redhat.com/browse/RHEL-40799

Then bump to Buildah v1.33.9

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@TomSweeneyRedHat TomSweeneyRedHat added the No New Tests Allow PR to proceed without adding regression tests label Jul 17, 2024
As the title says, bumping to v1.33.9 to incorporate
the JFrog fix.

[NO NEW TESTS NEEDED]

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/jfrog-1.33 branch from 7ef1729 to c56554e Compare July 17, 2024 18:35
@TomSweeneyRedHat
Copy link
Member Author

@lsm5 I've just pushed the button to rerun the tests again, is there anything else I can do to cure the packet errors here?

@lsm5
Copy link
Member

lsm5 commented Jul 17, 2024

@lsm5 I've just pushed the button to rerun the tests again, is there anything else I can do to cure the packet errors here?

the current packit targets are stale. Ignore them. If we absolutely need packit to pass here, we'll need to use the right targets.

@TomSweeneyRedHat
Copy link
Member Author

@edsantiago @lsm5 I hit a Docker rate limit now on this, and prior, we'd run into Packit issues. Any advice on how we can move this along? We need it for the Jira cards above.

@nalind
Copy link
Member

nalind commented Aug 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a77bd8e into containers:release-1.33 Aug 5, 2024
30 of 34 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm locked - please file new issue/PR No New Tests Allow PR to proceed without adding regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants