Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud image for IBM Cloud #775

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

javipolo
Copy link
Collaborator

@javipolo javipolo commented Sep 4, 2024

No description provided.

Verified

This commit was signed with the committer’s verified signature.
javipolo Javi Polo
Signed-off-by: Javi Polo <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 4, 2024

LGTM
I guess we don't have one for azure?

@rhatdan rhatdan merged commit c05cd05 into containers:main Sep 4, 2024
1 check passed
@@ -16,7 +16,7 @@ Please refer to the official RHEL AI documentation on how to create machine imag

| Variable | Description | Default |
|---------------------------|-------------------------------------------------|--------------------------------------------------------------|
| CLOUD | Sets the name of the cloud: aws, gcp, azure, ...| ` ` |
| CLOUD | Sets the name of the cloud: aws, gcp, ibm, ... | ` ` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the azure entry, rather than just adding a new option for IBM? I still see azure listed in source which is confusing me, please either do not remove it from these docs, or remove it from source.

@javipolo javipolo deleted the ibmcloud branch September 4, 2024 13:04
@javipolo
Copy link
Collaborator Author

javipolo commented Sep 4, 2024

@rhatdan @Gregory-Pereira I just removed one of the clouds to fit another one in the example, but seeing how it looked like, I just created a new PR that lists all the supported clouds:
#776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants