Fix Tests: Update portmap test's iptables error check #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyShepherd
force-pushed
the
fix-ci
branch
2 times, most recently
from
cc95e7a to
9a42204
Compare
EmilyShepherd
force-pushed
the
fix-ci
branch
3 times, most recently
from
a56b728 to
125a98c
Compare
GitHub Actions recently updated ubuntu-latest to 22.04 [1], which now defaults to nfttables (rather than iptables-legacy) [2]. The portmap tests in this project are written with the expectation that expected error message for one test is in the iptables-legacy format. This commit updates the check to make it work for both the iptables-legecy and iptables-nftables variants. References: [1]: actions/runner-images@4aba37b [2]: https://ubuntu.com/blog/whats-new-in-security-for-ubuntu-22-04-lts Signed-off-by: Emily Shepherd <[email protected]>
EmilyShepherd
changed the title
EmilyShepherd
changed the title
This was referenced Dec 6, 2022
Closed
Merged
austinvazquez
approved these changes
Dec 7, 2022
|
LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions recently updated ubuntu-latest to 22.04 [1], which now
defaults to nfttables (rather than iptables-legacy) [2]. The portmap
tests in this project are written with the expectation that expected
error message for one test is in the iptables-legacy format.
This commit updates the check to make it work for both the
iptables-legecy and iptables-nftables variants.
References:
[1]: actions/runner-images@4aba37b
[2]: https://ubuntu.com/blog/whats-new-in-security-for-ubuntu-22-04-lts
Signed-off-by: Emily Shepherd [email protected]