clean up : fix staticcheck warnings #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Ma <[email protected]>
jellonek
reviewed
Jun 19, 2019
bboreham
approved these changes
Jun 19, 2019
pkg/invoke/args.go
Outdated
| @@ -32,7 +32,7 @@ type inherited struct{} | |||
|
|
|||
| var inheritArgsFromEnv inherited | |||
|
|
|||
| func (_ *inherited) AsEnv() []string { | |||
| func (i *inherited) AsEnv() []string { | |||
There was a problem hiding this comment.
the recommendation from staticcheck is "omit the name if it is unused"
There was a problem hiding this comment.
Updated, thanks! @bboreham
Signed-off-by: Bruce Ma <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref to #642
try to fix some warnings generated by staticcheck