-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI fix, part I: update and cleanup #606
Conversation
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
…ntainer Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
Signed-off-by: apostasie <[email protected]>
e0992cf
to
fc7da25
Compare
@imeoer fixing kube tests will take more work, that I would like to do in a separate PR, so, I am removing my "kube" commit from here for now. This here is just dealing with the rest. Do you mind having a look at this at your convenience so that we can rebase other ongoing work? |
Also, I did split "unrelated" changes into separate commits so that "history" is easier to review, but of course happy to squash if you prefer that. |
Note: we might want to pin delve to a specific version to avoid being forced into the same situation wrt golang version later on. |
Signed-off-by: apostasie <[email protected]>
LGTM, thanks for the hard work! |
You welcome @imeoer :) |
Work on #604 required a set of changes, fixes and updates to the test rig and CI, and has grown really large.
This PR does split out some of the more minor changes to make it easier to review.
Furthermore, the CI is in a shaky state right now and is just red, as the build fails because of delve latest being dependent on a more recent version of go (which in turns requires a series of changes), and also as #603 seems to break e2e kube tests (or this test is very flaky).
Changes: