This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Make changes needed to compile on CoffeeScript 2 #32
+4,223
−4,282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 4 sources of breakages: - `super` must be called in extended classes with constructors. - Class prototype methods are non-enumerable, so `util.extend` had to be updated to use `Object.getOwnPropertyNames` and `Object.getPrototypeOf`. - Default arguments will only be used for `undefined` values, which broke a test setup in `test/test.coffee`. - Due to `super` needing to be called before `@` parameters are availble, the stack set by `YAMLError#constructor` was calling `#toString` of subclasses whose `@` parameters were not yet available. The chosen fix was to make `#stack` a getter.
connec
force-pushed
the
coffeescript2
branch
from
acac68b to
1ab5166
Compare
|
Implemented in 77896d3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can't be merged until CoffeeScript 2 is released and connec/plantation has been upgraded to it.
There were 4 sources of breakages:
supermust be called in extended classes with constructors.util.extendhad to beupdated to use
Object.getOwnPropertyNamesandObject.getPrototypeOf.undefinedvalues, whichbroke a test setup in
test/test.coffee.superneeding to be called before@parameters areavailble, the stack set by
YAMLError#constructorwas calling#toStringof subclasses whose@parameters were not yet available.The chosen fix was to make
#stacka getter.