Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty response from server when running curl on music demo app #279

Open
wants to merge 1 commit into
base: 5.3.0-post
Choose a base branch
from

Conversation

pantrif
Copy link
Contributor

@pantrif pantrif commented Aug 4, 2019

This allows curling the music demo app outside of the running container.

@ghost
Copy link

ghost commented Aug 4, 2019

@confluentinc It looks like @pantrif just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@pantrif pantrif changed the title Fix empty response from server when running curling music demo app Fix empty response from server when running curl on music demo app Aug 4, 2019
@ableegoldman
Copy link

@pantrif Hi! You submitted this PR fairly soon after we merged (we think) a fix for this issue, where we changed KAFKA_MUSIC_APP_REST_HOST from localhost to 0.0.0.0. I just want to confirm, were you hitting this issue before or also after we made the above change?

ie did you test the demo app with host 0.0.00 or was it still localhost when running into this?

@ableegoldman
Copy link

ableegoldman commented Aug 6, 2019

Regardless of the above, we do ultimately want to set this to kafka-music-application as you've done. I believe this patch should be applied to 5.1.3 branch and later -- could you retarget the PR against 5.1.3-post so we can merge it downstream from there? You may need to rebase, or feel free to just open a new PR and ping us.

Thanks!

@pantrif
Copy link
Contributor Author

pantrif commented Aug 6, 2019

Hello @ableegoldman!! Indeed I submit this fix a few minutes after you merged. The localhost part was the problematic one. So I was hitting this issue before you make the above change.
However, I tried a few things of my own like setting the host to 127.0.0.1 or to 0.0.0.0 like you did and both seems to work just fine.
But I believe since you have already set up a host in the docker-compose file (hostname: kafka-music-application) I found better to provide that host (because 0.0.0.0 is too generic)

@pantrif pantrif changed the base branch from master to 5.2.0-post August 6, 2019 05:27
@pantrif pantrif changed the base branch from 5.2.0-post to 5.1.3-post August 6, 2019 05:28
@pantrif pantrif changed the base branch from 5.1.3-post to 5.3.0-post August 6, 2019 05:30
Copy link

cla-assistant bot commented Jul 11, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants