Added support for custom metrics #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added MXBean for exporting connector metrics through JMX * Since connector Batch mode load-job-runnables do not have observability, added custom metrics to expose numbers around number of active jobs, storage-blobs etc. * made custom metrics are easily expandable for metrics around various other elements of the connector
|
@pbadani @b-goyal @aniketshrimal Hi Guys can you please review this PR |
|
Will this PR not be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As of now the connector only exposes standard Kafka Connect MBeans metrics, but we do have lot of operations happening in connector runtime where we are missing observability. This PR adds support for exposing custom metrics from the connector runtime by adding custom JMX MBeans.
Changes
Testing
Tested the exported metrics locally with the Jconsole, I am able to see metrics exported from all tasks of the connector.
Note