Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Streams init #815

Open
wants to merge 1 commit into
base: 6.0.0-post
Choose a base branch
from
Open

Cleanup Streams init #815

wants to merge 1 commit into from

Conversation

simPod
Copy link

@simPod simPod commented Sep 30, 2020

Remove handling of "Streams never finished rebalancing on startup" as it's no longer required (I believe it is some relict to prevent a bug that existed in Kafka v0.x)

Verified

This commit was signed with the committer’s verified signature.
bentsherman Ben Sherman
Remove handling of "Streams never finished rebalancing on startup" as it's no longer required
Copy link
Contributor

@ybyzek ybyzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simPod these changes cannot be made independently from the original source code at https://github.com/confluentinc/kafka-streams-examples/tree/6.0.0-post/src/main/java/io/confluent/examples/streams/microservices . The files here are from that kafka-streams-examples repo, with certain lines removed. So this PR could only be approved if the corresponding changes are first merged in kafka-streams-examples

@simPod
Copy link
Author

simPod commented Oct 9, 2020

confluentinc/kafka-streams-examples#364

Copy link

cla-assistant bot commented Apr 28, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants