Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #1039

Open
wants to merge 1 commit into
base: 6.2.1-post
Choose a base branch
from
Open

Update package.json #1039

wants to merge 1 commit into from

Conversation

ecukuroglu
Copy link
Member

@ecukuroglu ecukuroglu commented Sep 30, 2021

Description

https://confluentinc.atlassian.net/browse/DEVX-2677

What behavior does this PR change, and why?

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

@ybyzek ybyzek requested a review from avoguru September 30, 2021 12:12
@ybyzek
Copy link
Contributor

ybyzek commented Sep 30, 2021

@avoguru can you please confirm that this PR works in your environment?

Copy link

@avoguru avoguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version change works. Docs needs improvement, the installation process needs more clarity (raised a internal jira for the same - DEVX-2677)

@ybyzek
Copy link
Contributor

ybyzek commented Oct 1, 2021

@avoguru can you please elaborate on improvement needed in the installation process? The source doc lives in this repo, so it could optionally be fixed in this PR as well.

https://github.com/confluentinc/examples/blob/6.2.1-post/clients/docs/nodejs.rst

Copy link

cla-assistant bot commented Apr 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants